Docs: upgrade to Create React App 4 #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for gestalt ready! Built with commit 7e06bb0 |
christianvuerings
force-pushed
the
cra4
branch
from
d275bba
to
7c8c20f
Compare
christianvuerings
force-pushed
the
cra4
branch
from
7c8c20f
to
7e06bb0
Compare
| @@ -55,8 +55,8 @@ describe('Button', () => { | |||
| render(<Button text="test" disabled ref={ref} />); | |||
| expect(ref.current instanceof HTMLButtonElement).toEqual(true); | |||
| expect( | |||
| ref.current instanceof HTMLButtonElement && ref.current?.tabIndex | |||
There was a problem hiding this comment.
@AlbertCarreras could you verify that this is correct?
When I looked at a disabled <Button />, we only set the disabled attribute, we do not set the tabIndex:
- Go to https://gestalt.netlify.app/Button
- Toggle
Disable buttons - Inspect the HTML in the Chrome devtools
- No
tabIndexis set on the button
There was a problem hiding this comment.
| </Switch> | ||
| </App> | ||
| </BrowserRouter> | ||
| <AppWrapper /> |
There was a problem hiding this comment.
@ayeshakmaz @AlbertCarreras fyi had to move this wrapper outside of index.js since otherwise fast refresh does not detect incremental changes to the docs
AlbertCarreras
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md#400-2020-10-23
Test Plan
yarn start