[#1] guard markdown contents

pinpoint-apm · Nov 9, 2021 · d88c5bb · d88c5bb
1 parent c0c14b4
commit d88c5bb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/actions/markdown-template-engine-action/index.js b/.github/actions/markdown-template-engine-action/index.js
@@ -46,7 +46,7 @@ const run = async () => {
 
     const markdownContent = await engine.markdownContent(githubRelease)
     const disableChanges = core.getInput('disable_sync_changes')
-    if (disableChanges.length == 0) {
+    if (markdownContent && disableChanges.length == 0) {
       fs.outputFileSync(templateMarkdownFile, markdownContent)
     }
     core.setOutput('markdown', markdownContent)

diff --git a/.github/actions/markdown-template-engine-action/lib/markdown-contents.js b/.github/actions/markdown-template-engine-action/lib/markdown-contents.js
@@ -31,7 +31,7 @@ class MarkdownContents {
         }
         const match = RegExp(`^<!--\\s<${filename}>\\s-->$\\s(?<body>[\\s\\S]*)^<!--\\s<\\/${filename}>\\s-->`, 'gm').exec(readmeGithubBody)
         if (!match) {
-            return new MarkdownContents('')
+            return new MarkdownContents()
         }
         return new MarkdownContents(match.groups.body)
     }

diff --git a/.github/actions/markdown-template-engine-action/lib/template-engine.js b/.github/actions/markdown-template-engine-action/lib/template-engine.js
@@ -23,6 +23,9 @@ class TemplateEngine {
         let result = this.template
         while ((tag = tagExpression.exec(this.template)) !== null) {
             const markdownFile = await this.markdownContentFromGithub(tag[1], githubRelease)
+            if (!markdownFile) {
+                return
+            }
             result = result.replace(RegExp(`<!--\\s<${tag[1]}>\\s-->\\n[\\s\\S]*<!--\\s<\\/${tag[1]}>\\s-->`, 'm'), `<!-- <${tag[1]}> -->\n${markdownFile}\n<!-- </${tag[1]}> -->`)
         }
         return result