[#1] fix latest release notes no refresh bug

pinpoint-apm · Nov 3, 2021 · 4646492 · 4646492
1 parent 5b2ec14
commit 4646492
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.github/actions/markdown-template-engine-action/lib/github-release.js b/.github/actions/markdown-template-engine-action/lib/github-release.js
@@ -48,6 +48,10 @@ class GithubRelease {
     commitLog() {
         return `${this.name} tag: ${this.tagName} ${this.htmlURL}`
     }
+
+    getTagName() {
+        return this.tagName
+    }
 }
 
 module.exports = GithubRelease
diff --git a/.github/actions/markdown-template-engine-action/lib/release-notes.js b/.github/actions/markdown-template-engine-action/lib/release-notes.js
@@ -24,12 +24,10 @@ class ReleaseNotes {
         return `v${this.version}`
     }
 
-    static async makeLatestReleaseNotes(releaseClass) {
-        const data = await releaseClass.latest()
-
-        const tagName = ReleaseNotes.tagName(data.tag_name)
+    static makeLatestReleaseNotes(release) {
+        const tagName = ReleaseNotes.tagName(release.getTagName())
         const latestReleaseNotes = whatsNewTempate.replace('__VERSION__', tagName)
-            .replace('__BODY__', data.body)
+            .replace('__BODY__', release.getBody())
         return new ReleaseNotes(latestReleaseNotes, tagName)
     }
 

diff --git a/.github/actions/markdown-template-engine-action/lib/template-engine.js b/.github/actions/markdown-template-engine-action/lib/template-engine.js
@@ -10,6 +10,7 @@ const github = require('@actions/github')
 const fs = require("fs-extra")
 const axios = require('axios')
 const MarkdownContents = require('./markdown-contents')
+const ReleaseNotes = require('./release-notes')
 
 class TemplateEngine {
     constructor(template) {
@@ -40,7 +41,7 @@ const githubs = {
     valueOfFilename: async function (filename, release) {
         switch (filename) {
             case 'latestReleaseNotes.md':
-                return release.getBody()
+                return ReleaseNotes.makeLatestReleaseNotes(release).contents
             default:
                 return (await MarkdownContents.makeMarkdownContentsFromPinpointReadme(filename)).contents
         }