Add child method default generic type #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusvellone
added a commit
to matheusvellone/pino
that referenced
this pull request
May 3, 2023
|
Just force-pushed a change to add test for the type, to avoid bug from comming back |
joelmukuthu
reviewed
Jul 21, 2023
| @@ -80,7 +80,7 @@ interface LoggerExtras<Options = LoggerOptions> extends EventEmitter { | |||
| * @param options: an options object that will override child logger inherited options. | |||
| * @returns a child logger instance. | |||
| */ | |||
| child<ChildOptions extends pino.ChildLoggerOptions>(bindings: pino.Bindings, options?: ChildOptions): pino.Logger<Options & ChildOptions>; | |||
| child<ChildOptions extends pino.ChildLoggerOptions = {}>(bindings: pino.Bindings, options?: ChildOptions): pino.Logger<Options & ChildOptions>; | |||
There was a problem hiding this comment.
Hi @matheusvellone, I'm wondering if pino.ChildLoggerOptions would have been a better default or do you have some reservations against it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1703