Async by default #1448
Merged
Async by default #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100% code coverage back.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
kibertoad
reviewed
May 31, 2022
kibertoad
reviewed
May 31, 2022
Co-authored-by: Igor Savin <iselwin@gmail.com>
Co-authored-by: Igor Savin <iselwin@gmail.com>
kibertoad
approved these changes
May 31, 2022
jsumners
approved these changes
May 31, 2022
|
Tests didn't need to be updated? |
Co-authored-by: James Sumners <james@sumners.email>
|
No. Async and sync logging are functionally equivalent given the other semver-major changes. |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
9 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we are going to drop Node v12, we can actually be safe in enabling asynchronous logging everywhere.
This is based on top of #1249.