fix: type regression on fastify

[climba03003]

Fixes the type regression on fastify/fastify#3506

[kibertoad]

why move it from top level into a namespace?

[climba03003]

Because it never export outside and nobody can use.

[kibertoad]

can't we export it instead?

[climba03003]

Then the old way of import is missing this exportation.
e.g.

import pino from 'pino'
pino.BaseLogger

Top-level export is mapped on line 768

[kibertoad]

We generally want to move away from relying on namespace. See #1193 (comment)
I agree that types should be fixed if we lost the way to do something we could do before, though.

[climba03003]

I agree that it should move away from namespace, but the current version is too late to do it.
Current version should support the import syntax that can be used in 7.0.0.

The complete removal should be happen in next major 8.0.0.

[kibertoad]

I understand that we can't remove it yet, but can we at least already provide alternative for people who want to do direct named imports? That was the gist of #1193 and it seems like the right direction.
Other than that, PR LGTM.

[climba03003]

As I mention on line 768, it has the top-level export mapped.

[climba03003]

This PR already provide the type import for below format.

// named import
import { BaseLogger } from 'pino'
// namespace import / default import
import pino from 'pino'
pino.BaseLogger
// pino named import
import { pino } from 'pino'
pino.BaseLogger
// old P named import
import { P } from 'pino'
P.BaseLogger

If anything is missing, please let me know.

[kibertoad]

Thank you for clarification!

[climba03003]

I have tested even without my changes, it failed the test.

I have no idea why it failed by @types/jsdom type check and it is something that we never import.

[mcollina]

lgtm

[mcollina]

@climba03003 can you rebase?
@kibertoad fixed this in #1251.

[mcollina]

@kibertoad are you good with this landing?

[climba03003]

CI fail is not related to TypeScript changes.

[mcollina]

This can land as soon as @kibertoad approves. #1253 is to improve that test.

[climba03003]

@kibertoad I think here is what you mention?

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.