pass append option on pino/file transport to pino.destination function #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
reviewed
Nov 18, 2021
Comment on lines
7
to
10
| const destOpts = { dest: opts.destination || 1, sync: false } | ||
| if (opts.append === false) destOpts.append = false | ||
| if (opts.mkdir) destOpts.mkdir = true | ||
| const destination = pino.destination(destOpts) |
There was a problem hiding this comment.
Would this not be more comprehensive?
const destOpts = Object.assign({}, opts.destination, { dest: opts.destination || 1, sync: false })There was a problem hiding this comment.
That's certainly a valid approach, but it would expand the scope of this issue. If you prefer to forward all the options to the destination, I won't object. @mcollina, where do you stand on this?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
appendoption is specified on the pino/file transport, and the value isfalse, pass it to the pino.destination function.closes #1222