Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1167 (dedupe should write to all streams matching the target level) #1172

Merged
merged 2 commits into from Oct 19, 2021

Conversation

frzsombor
Copy link
Contributor

@frzsombor frzsombor commented Oct 18, 2021

Fixes #1167

@mcollina
Copy link
Member

could you please add a unit test?

@frzsombor
Copy link
Contributor Author

I've added a new test case, hope that it is something you expected to see

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9cc90e3 into pinojs:master Oct 19, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same level multistream logging is not working with "dedupe"
2 participants