Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transport option param to types #1156

Merged
merged 3 commits into from Oct 15, 2021
Merged

Add transport option param to types #1156

merged 3 commits into from Oct 15, 2021

Conversation

kibertoad
Copy link
Contributor

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

is pipeline supported?

@kibertoad
Copy link
Contributor Author

@mcollina You mean this?

import pino from 'pino'

const logger = pino({
  transport: {
    pipeline: [{
      target: './my-transform.js'
    }, {
      // Use target: 'pino/file' to write to stdout
      // without any change.
      target: 'pino-pretty'
    }]
  }
})

logger.info('hello world')

I'll check, probably still needs to be added

@mcollina
Copy link
Member

yes

@kibertoad
Copy link
Contributor Author

@mcollina Please take a look, and if it is correct, let's merge :)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 880968e into master Oct 15, 2021
@mcollina mcollina deleted the fix/transport-type branch October 15, 2021 15:23
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants