Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for pino.multistream #1152

Merged
merged 3 commits into from
Oct 14, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions pino.d.ts
Expand Up @@ -232,21 +232,21 @@ declare namespace P {
}

interface StreamEntry {
stream: WriteStream
level: Level
stream: DestinationStream
level?: Level
}

interface MultiStreamRes {
write: (data: any) => void,
add: (dest: Record<string, any>) => MultiStreamRes,
flushSync: () => void,
minLevel: number,
streams: WriteStream[],
streams: ({ stream: DestinationStream, level: number, id: number })[],
clone(level: Level): MultiStreamRes,
}

function multistream(
streamsArray: StreamEntry[], opts: P.MultiStreamOptions
streamsArray: StreamEntry[], opts?: P.MultiStreamOptions
): MultiStreamRes

/**
Expand Down
17 changes: 17 additions & 0 deletions test/types/pino-multistream.test-d.ts
@@ -0,0 +1,17 @@
import { expectType } from 'tsd'

import { createWriteStream } from 'fs'

import pino from '../../pino'

const streams = [
{ stream: process.stdout },
{ stream: createWriteStream('') },
{ level: 'error' as const, stream: process.stderr },
{ level: 'fatal' as const, stream: createWriteStream('') }
]

expectType<pino.MultiStreamRes>(pino.multistream(streams))
expectType<pino.MultiStreamRes>(pino.multistream(streams, {}))
expectType<pino.MultiStreamRes>(pino.multistream(streams, { levels: { 'info': 30 } }))
expectType<pino.MultiStreamRes>(pino.multistream(streams, { dedupe: true }))