Updating for v9: update dependencies and CI #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
requested changes
Oct 9, 2023
package.json
Outdated
| @@ -36,7 +36,7 @@ | |||
| "pre-commit": "^1.2.2", | |||
| "snazzy": "^9.0.0", | |||
| "standard": "^17.0.0", | |||
| "tap": "^15.0.10", | |||
| "tap": "^18.4.5", | |||
There was a problem hiding this comment.
We can't update tap. See the note in pinojs/pino#1762.
There was a problem hiding this comment.
Ah I see, so we leave it like it is, or we move the test suite to node:test
There was a problem hiding this comment.
For now, we should just leave it pinned to 16.3.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
As needed in issue #1762 and referenced here this pr is needed for pino v9.
I did not open an issue related but I will if needed, and I merged both CI and dependencies update, if you think it's better to provide two separate pr, I'll split them as well.
Thank you in advance!
@jsumners