Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to pino@7 #245

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Updated to pino@7 #245

merged 2 commits into from
Oct 14, 2021

Conversation

mcollina
Copy link
Member

This is an update to pino@7.
The main difference with handling errors is that now pino uses err property by default.

I retained the support of the previous (pino@6) syntax as well so it still works with pino@6.

I do not plan to bump the major unless anybody prefers otherwise (pino-pretty@7 was released to match pino@7)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1341500547

  • 0 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1336771127: 0.0%
Covered Lines: 318
Relevant Lines: 318

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 14, 2021

Pull Request Test Coverage Report for Build 1341761551

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1336771127: 0.0%
Covered Lines: 318
Relevant Lines: 318

💛 - Coveralls

lib/utils.js Outdated
@@ -187,7 +187,6 @@ function prettifyErrorLog ({
// Print all sibling properties except for the standard exclusions.
propertiesToPrint = Object.keys(log).filter(k => excludeProperties.includes(k) === false)
} else {
// Print only specified properties unless the property is a standard exclusion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, it was not intended.

@mcollina mcollina merged commit 35d3410 into master Oct 14, 2021
@jsumners jsumners deleted the update-pino branch October 14, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants