Add support for minimumLevel #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jsumners I think this would be a good feature to add. It's minimal and it was my only usecase for the previous search functionality. |
mcollina
reviewed
Sep 21, 2021
jsumners
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
There were a few leftover lines in
bin.jsfor the oldsearchflag (removed in #227), so I reused that example in this PR. (I also re-used the implementation and testing strategies from that old feature to implement this one.)I just wanted to get this feature as close to shippable as possible, please feel free to close this PR and re-implement a different way if this isn't the right approach. 馃憤