Skip to content

fix(genreqid): add param for server response #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Eji4h
Copy link
Contributor

@Eji4h Eji4h commented Sep 30, 2022

fix #250

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Oct 1, 2022

Can you add an assertion using tsd?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 59fc223 into pinojs:master Oct 2, 2022
@Eji4h
Copy link
Contributor Author

Eji4h commented Oct 2, 2022

Can you add "hacktoberfest-accepted" label? @mcollina

@Eji4h Eji4h deleted the bugfix/gen-req-id-interface-type-miss-match branch October 3, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenReqId interface does not have res specified resulting in typescript error
2 participants