New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(logger): remove unneeded defensive code #239

Merged

mcollina merged 1 commit into master from Fdawgs-patch-1

Jul 13, 2022

Member

Fdawgs commented Jul 13, 2022

autoLoggingIgnore is already checked to not be null on the line above:

pino-http/logger.js

Line 157 in 5d8a2f5

if (autoLoggingIgnore !== null && shouldLogSuccess === true) {


          refactor(logger): remove uneeded defensive code

e9bd35d

Fdawgs changed the title ~~refactor(logger): remove uneeded defensive code~~ refactor(logger): remove unneeded defensive code

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

mcollina merged commit 1fc4756 into master

Fdawgs deleted the Fdawgs-patch-1 branch

July 13, 2022 08:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment