Add back pino-related typings on IncomingMessage, OutgoingMessage and… #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ServerResponse. Fix a test that fails on Windows.
mcollina
reviewed
Nov 28, 2021
index.d.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| // Type definitions for pino-http 6.0 | |||
| // Type definitions for pino-http 6.x | |||
kibertoad
approved these changes
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ServerResponse.
Also fixed a test that fails on Windows (no /dev/null available, will print to STDOUT instead).
Ref. #175.
These additional typings are included in the @types/pino-http, so I just added them back in.