Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dependencies to the latest version #187

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Updated dependencies to the latest version #187

merged 1 commit into from
Apr 25, 2024

Conversation

mohammedbalila
Copy link
Contributor

This PR addresses this issue #186 for updating ping to v9

mcollina
mcollina requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’d need to increase the minimum node version in CI to v18.

@mohammedbalila
Copy link
Contributor Author

mohammedbalila commented Apr 24, 2024 •
edited

Hey @mcollina
Correct me if I'm wrong but I thought this snippet in the CI file guarantees that

    runs-on: ubuntu-latest
    permissions:
      contents: read
    strategy:
      matrix:
        node-version: [18, 20]

mcollina
mcollina approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mcollina mcollina merged commit 7980eaa into pinojs:master Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohammedbalila @mcollina