Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tests compatible with Node 18 and 20 #94

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

donwellus
Copy link
Contributor

fixes #93

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mcollina
Copy link
Member

Could you add Node.js v20 to

node-version: [14, 16, 18]
?

@mcollina mcollina merged commit 0203d24 into pinojs:main Apr 22, 2024
11 checks passed
@donwellus
Copy link
Contributor Author

Hi @mcollina o/
I'm sorry for the delay to answer you, I saw that you already changed the node-version. Thank you 👍

@donwellus donwellus deleted the test/fix-broken-json-node-20 branch April 22, 2024 12:49
renovate bot added a commit to redwoodjs/redwood that referenced this pull request May 16, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[pino-abstract-transport](https://togithub.com/pinojs/pino-abstract-transport)
| [`1.1.0` ->
`1.2.0`](https://renovatebot.com/diffs/npm/pino-abstract-transport/1.1.0/1.2.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-abstract-transport
(pino-abstract-transport)</summary>

###
[`v1.2.0`](https://togithub.com/pinojs/pino-abstract-transport/releases/tag/v1.2.0)

[Compare
Source](https://togithub.com/pinojs/pino-abstract-transport/compare/v1.1.0...v1.2.0)

#### What's Changed

- build(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#80
- build(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#82
- build(deps-dev): bump tsd from 0.28.1 to 0.30.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#83
- build(deps-dev): bump husky from 8.0.3 to 9.0.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#84
- build(deps): bump actions/cache from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#85
- docs(readme): fix broken badge URLs by
[@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in
[pinojs/pino-abstract-transport#88
- refactor: remove objectMode argument as it is ignored by Duplex.from
by [@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker)
in
[pinojs/pino-abstract-transport#89
- build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#91
- feat: load config from pino on startup by
[@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in
[pinojs/pino-abstract-transport#90
- Make the tests compatible with Node 18 and 20 by
[@&#8203;donwellus](https://togithub.com/donwellus) in
[pinojs/pino-abstract-transport#94

#### New Contributors

- [@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker)
made their first contribution in
[pinojs/pino-abstract-transport#88
- [@&#8203;donwellus](https://togithub.com/donwellus) made their first
contribution in
[pinojs/pino-abstract-transport#94

**Full Changelog**:
pinojs/pino-abstract-transport@v1.1.0...v1.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Josh-Walker-GM pushed a commit to redwoodjs/redwood that referenced this pull request May 17, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[pino-abstract-transport](https://togithub.com/pinojs/pino-abstract-transport)
| [`1.1.0` ->
`1.2.0`](https://renovatebot.com/diffs/npm/pino-abstract-transport/1.1.0/1.2.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-abstract-transport
(pino-abstract-transport)</summary>

###
[`v1.2.0`](https://togithub.com/pinojs/pino-abstract-transport/releases/tag/v1.2.0)

[Compare
Source](https://togithub.com/pinojs/pino-abstract-transport/compare/v1.1.0...v1.2.0)

#### What's Changed

- build(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#80
- build(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#82
- build(deps-dev): bump tsd from 0.28.1 to 0.30.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#83
- build(deps-dev): bump husky from 8.0.3 to 9.0.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#84
- build(deps): bump actions/cache from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#85
- docs(readme): fix broken badge URLs by
[@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in
[pinojs/pino-abstract-transport#88
- refactor: remove objectMode argument as it is ignored by Duplex.from
by [@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker)
in
[pinojs/pino-abstract-transport#89
- build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino-abstract-transport#91
- feat: load config from pino on startup by
[@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in
[pinojs/pino-abstract-transport#90
- Make the tests compatible with Node 18 and 20 by
[@&#8203;donwellus](https://togithub.com/donwellus) in
[pinojs/pino-abstract-transport#94

#### New Contributors

- [@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker)
made their first contribution in
[pinojs/pino-abstract-transport#88
- [@&#8203;donwellus](https://togithub.com/donwellus) made their first
contribution in
[pinojs/pino-abstract-transport#94

**Full Changelog**:
pinojs/pino-abstract-transport@v1.1.0...v1.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are not passing on Node 20
2 participants