Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for pino@9 #87

Merged
merged 10 commits into from
Apr 6, 2024
Merged

Update for pino@9 #87

merged 10 commits into from
Apr 6, 2024

Conversation

jsumners
Copy link
Member

Part of pinojs/pino#1762.

jsumners
jsumners commented Mar 10, 2024
View reviewed changes
test/base.test.js Outdated Show resolved Hide resolved
@jsumners jsumners requested a review from mcollina March 10, 2024 14:06
@mcollina
Copy link
Member

CI doesn't seem happy

@jsumners
Copy link
Member Author

CI doesn't seem happy

Yeah. See my inline review comment.

@jsumners jsumners changed the title Update for pino@5 Update for pino@9 Mar 11, 2024
@jsumners
Copy link
Member Author

I give up for now. node:test in v16 doesn't include t.after so tspl isn't usable. But we need tspl to assert the planned number of assertions. This PR has completely convinced me that the functionality belongs in node:test and the reasoning of "we want all assertion libraries to work" is a cop out.

mcollina
mcollina approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners merged commit 2cdc122 into next Apr 6, 2024
16 checks passed
@jsumners jsumners deleted the prep-v5 branch April 6, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v9 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsumners @mcollina