fix!: prevent req being added twice to the response and request start log
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt log There is no way to know in the response log event handling if the request was already added through the child bindings in `onRequest`. And there was no way as a user to fix this behaviour properly. So now `req` will be added once but you need to make sure that you pass it in `childBindings` for the response. Request start event will have it regardless but also only once. This is a breaking change as some people will have removed the `req` from the `childBindings` to get around this issue. Fixes #91
|
I added a fix to the commit to make it compatible with the changes of #156 |
|
There is one more conflict :( |
|
Fixed ✨ |
|
Thanks Adri! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to know in the response log event handling if the request was already added through the child bindings in
onRequest.And there was no way as a user to fix this behaviour properly.
So now
reqwill be added once but you need to make sure that you pass it inchildBindingsfor the response.Request start event will have it regardless but also only once.
This is a breaking change as some people will have removed the
reqfrom thechildBindingsto get around this issue.Fixes #91