Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: prevent req being added twice to the response and request start log #157

Merged
merged 2 commits into from Mar 16, 2022
Merged

Commits on Mar 15, 2022

  1. fix!: prevent req being added twice to the response and request sta…

    …rt log
    
    There is no way to know in the response log event handling if the request was already added through the child bindings in `onRequest`.
    And there was no way as a user to fix this behaviour properly.
    
    So now `req` will be added once but you need to make sure that you pass it in `childBindings` for the response.
    Request start event will have it regardless but also only once.
    
    This is a breaking change as some people will have removed the `req` from the `childBindings` to get around this issue.
    
    Fixes #91
    AdriVanHoudt committed Mar 15, 2022
    Copy the full SHA
    7d5d240 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e803882 View commit details
    Browse the repository at this point in the history