Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: implement polling and retries in test #731

Merged
merged 5 commits into from
Apr 4, 2024
Merged

test: implement polling and retries in test #731

merged 5 commits into from
Apr 4, 2024

Conversation

juliusmarminge
Copy link
Collaborator

@juliusmarminge juliusmarminge commented Mar 25, 2024 •
edited

more tests to improve confidence of Effect rewrite

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2024 •
edited

⚠️ No Changeset found

Latest commit: 9961ab2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliusmarminge juliusmarminge marked this pull request as draft March 25, 2024 11:51
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 11:08pm

juliusmarminge
juliusmarminge commented Mar 25, 2024
View reviewed changes
patches/msw+2.2.10.patch Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: https://github.com/mswjs/msw/pull/2108/files

juliusmarminge
juliusmarminge commented Mar 25, 2024
View reviewed changes
packages/uploadthing/src/internal/multi-part.ts
@@ -113,7 +113,7 @@ export async function uploadPartWithProgress(
// Add a delay before retrying (exponential backoff can be used)
const delay = Math.pow(2, retryCount) * 1000;
await new Promise((res) => setTimeout(res, delay));
await uploadPartWithProgress(opts, retryCount + 1); // Retry the request
resolve(await uploadPartWithProgress(opts, retryCount + 1)); // Retry the request
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how funny that when validating the new solution i think i found a bug in the current solution xddd

the promise never resolved if it retried so it just hang forever 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@juliusmarminge juliusmarminge marked this pull request as ready for review April 4, 2024 09:20
@juliusmarminge
Copy link
Collaborator Author

juliusmarminge commented Apr 4, 2024 •
edited

Upstream PR (mswjs/msw#2108) looks fine, some incompatiblities with older ts versions but fine to merge for now with patch i think

@juliusmarminge juliusmarminge merged commit 15b567d into main Apr 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markflorkowski markflorkowski markflorkowski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliusmarminge @markflorkowski