Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(all): bump the golanglint-ci to 1.52.2 #8844

Merged
merged 7 commits into from
Apr 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ linters-settings:
- name: var-naming
- name: package-comments
- name: range
# - name: receiver-naming TODO: disable it because it can't handle generics
- name: receiver-naming
- name: indent-error-flow
- name: superfluous-else
- name: modifies-parameter
Expand Down
8 changes: 4 additions & 4 deletions cdc/api/v2/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,19 @@ type mockPDClient struct {
}

// UpdateServiceGCSafePoint mocks the corresponding method of a real PDClient
func (m *mockPDClient) UpdateServiceGCSafePoint(ctx context.Context,
func (c *mockPDClient) UpdateServiceGCSafePoint(ctx context.Context,
serviceID string, ttl int64, safePoint uint64,
) (uint64, error) {
return safePoint, nil
}

// GetTS of mockPDClient returns a mock tso
func (m *mockPDClient) GetTS(ctx context.Context) (int64, int64, error) {
return m.logicTime, m.timestamp, nil
func (c *mockPDClient) GetTS(ctx context.Context) (int64, int64, error) {
return c.logicTime, c.timestamp, nil
}

// GetClusterID of mockPDClient returns a mock ClusterID
func (m *mockPDClient) GetClusterID(ctx context.Context) uint64 {
func (c *mockPDClient) GetClusterID(ctx context.Context) uint64 {
return 123
}

Expand Down
8 changes: 4 additions & 4 deletions cdc/model/sink.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,17 +273,17 @@ type RedoDDLEvent struct {
}

// ToRedoLog converts row changed event to redo log
func (row *RowChangedEvent) ToRedoLog() *RedoLog {
func (r *RowChangedEvent) ToRedoLog() *RedoLog {
return &RedoLog{
RedoRow: RedoRowChangedEvent{Row: row},
RedoRow: RedoRowChangedEvent{Row: r},
Type: RedoLogTypeRow,
}
}

// ToRedoLog converts ddl event to redo log
func (ddl *DDLEvent) ToRedoLog() *RedoLog {
func (d *DDLEvent) ToRedoLog() *RedoLog {
return &RedoLog{
RedoDDL: RedoDDLEvent{DDL: ddl},
RedoDDL: RedoDDLEvent{DDL: d},
Type: RedoLogTypeDDL,
}
}
Expand Down
220 changes: 0 additions & 220 deletions cdc/verification/checker.go

This file was deleted.