pkg: add a new retry to support the error isRetryable or not

[ben1009]

What problem does this PR solve?

• intention is try to solve Fail-fast for unrecoverable DML errors Fail-fast for unrecoverable DML errors #1724, for now add a new retry pkg, will try to replace the current retry usage later
• add functional options feature to better support extend the retry ability
• return ctx.Error() when got canceled instead of just return err, for more detail check Give reason for Stop cenkalti/backoff#97
• support RunWithInfiniteRetry and RunSpecificTimesRetry in one func with WithInfiniteTries, WithMaxTries Option
• change the param from WithMaxRetries to WithMaxTries for better understanding

        just paste some comments from test

        err := Run(500*time.Millisecond, 3, f)
	c.Assert(err, check.ErrorMatches, "test")
	// It's weird that backoff may retry one more time than maxTries.
	// Because the steps in backoff.Retry is:
	// 1. Call function
	// 2. Compare numTries and maxTries
	// 3. Increment numTries
	c.Assert(callCount, check.Equals, 3+1)

What is changed and how it works?

add a new implementation of retry to support config error retry or not

Check List

Tests

• Unit test

Code changes

• Has new function added

Related changes

• Need to cherry-pick to the release branch

Release note

[liuzix]

Can we make use of github.com/cenkalti/backoff?

[ben1009]

Can we make use of github.com/cenkalti/backoff?

i also want reuse github.com/cenkalti/backoff at the first place, but after check the code, seems rewrite could be easier than add the feature i want in the pkg, for instance check the issues https://github.com/cenkalti/backoff/issues

[overvenus]

What's your next step in solving #1724?

[ben1009]

What's your next step in solving #1724?

will make the change in another pr, since have 10+ usage exclude tests, do not want involve too many changes in one place.

• replace current retry pkg with this one
• config WithIsRetryableErr for differenet cases
• add more tests

[ben1009]

/run-all-tests

[ben1009]

/run-integration-tests

[ben1009]

/run-kafka-tests

[ben1009]

/run-kafka-tests

[ben1009]

/run-kafka-tests

[overvenus]

LGTM

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• amyangfei
• overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[overvenus]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 6493364

[ben1009]

/run-integration-tests

[codecov-commenter]

Codecov Report

Merging #1848 (13dea49) into master (0138edc) will increase coverage by 14.7797%.
The diff coverage is 60.9587%.

@@                Coverage Diff                @@
##             master      #1848         +/-   ##
=================================================
+ Coverage   37.8006%   52.5803%   +14.7797%     
=================================================
  Files           110        171         +61     
  Lines         11394      18583       +7189     
=================================================
+ Hits           4307       9771       +5464     
- Misses         6662       7762       +1100     
- Partials        425       1050        +625     

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #2157.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #2158.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #2159.