*(cdc): accept access denied error when query tidb_version (#11129) #11139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
lgtm
release-note-none
ti-chi-bot
bot
added
the
do-not-merge/cherry-pick-not-approved
|
/test verify |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #11139 +/- ##
================================================
Coverage ? 57.4656%
================================================
Files ? 852
Lines ? 125917
Branches ? 0
================================================
Hits ? 72359
Misses ? 48143
Partials ? 5415 |
lidezhu
approved these changes
May 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
bot
removed
the
do-not-merge/cherry-pick-not-approved
|
/retest |
|
/test dm-integration-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #11129
What problem does this PR solve?
Issue Number: close #11128
What is changed and how it works?
When the downstream is a mysql cluster behind a workload balancer on the cloud, the workload balancer may provide an access point using domain name;
When cdc access the downstream using the domain name, the connection will use database
information_schemaautomatically. In this case, when queryselect tidb_version(), the downstream will report error for non-root user like: Access denied for user xxx to database 'information_schema'.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note