Skip to content

Commit

Permalink
*(all): bump the golanglint-ci to 1.52.2 (#8844)
Browse files Browse the repository at this point in the history
ref #2162
  • Loading branch information
hi-rustin committed Apr 27, 2023
1 parent c5add2f commit 39eb8f2
Show file tree
Hide file tree
Showing 16 changed files with 144 additions and 673 deletions.
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ linters-settings:
- name: var-naming
- name: package-comments
- name: range
# - name: receiver-naming TODO: disable it because it can't handle generics
- name: receiver-naming
- name: indent-error-flow
- name: superfluous-else
- name: modifies-parameter
Expand Down
8 changes: 4 additions & 4 deletions cdc/api/v2/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,19 @@ type mockPDClient struct {
}

// UpdateServiceGCSafePoint mocks the corresponding method of a real PDClient
func (m *mockPDClient) UpdateServiceGCSafePoint(ctx context.Context,
func (c *mockPDClient) UpdateServiceGCSafePoint(ctx context.Context,
serviceID string, ttl int64, safePoint uint64,
) (uint64, error) {
return safePoint, nil
}

// GetTS of mockPDClient returns a mock tso
func (m *mockPDClient) GetTS(ctx context.Context) (int64, int64, error) {
return m.logicTime, m.timestamp, nil
func (c *mockPDClient) GetTS(ctx context.Context) (int64, int64, error) {
return c.logicTime, c.timestamp, nil
}

// GetClusterID of mockPDClient returns a mock ClusterID
func (m *mockPDClient) GetClusterID(ctx context.Context) uint64 {
func (c *mockPDClient) GetClusterID(ctx context.Context) uint64 {
return 123
}

Expand Down
8 changes: 4 additions & 4 deletions cdc/model/sink.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,17 +273,17 @@ type RedoDDLEvent struct {
}

// ToRedoLog converts row changed event to redo log
func (row *RowChangedEvent) ToRedoLog() *RedoLog {
func (r *RowChangedEvent) ToRedoLog() *RedoLog {
return &RedoLog{
RedoRow: RedoRowChangedEvent{Row: row},
RedoRow: RedoRowChangedEvent{Row: r},
Type: RedoLogTypeRow,
}
}

// ToRedoLog converts ddl event to redo log
func (ddl *DDLEvent) ToRedoLog() *RedoLog {
func (d *DDLEvent) ToRedoLog() *RedoLog {
return &RedoLog{
RedoDDL: RedoDDLEvent{DDL: ddl},
RedoDDL: RedoDDLEvent{DDL: d},
Type: RedoLogTypeDDL,
}
}
Expand Down
220 changes: 0 additions & 220 deletions cdc/verification/checker.go

This file was deleted.

0 comments on commit 39eb8f2

Please sign in to comment.