Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: column pruning should use a shallow copy slice #53237

Merged
merged 1 commit into from
May 16, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented May 13, 2024

What problem does this PR solve?

Issue Number: close #52768

Problem Summary:

What changed and how does it work?

The slice passed to the column pruning should be shallow copied.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros
Copy link
Member Author

winoros commented May 13, 2024

The test in the issue is too long. I'm trying to simplify it.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3534%. Comparing base (37b29bd) to head (8c1b9cf).
Report is 25 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53237        +/-   ##
================================================
+ Coverage   72.4582%   75.3534%   +2.8952%     
================================================
  Files          1493       1498         +5     
  Lines        429362     437144      +7782     
================================================
+ Hits         311108     329403     +18295     
+ Misses        98985      87817     -11168     
- Partials      19269      19924       +655     
Flag Coverage Δ
integration 50.2045% <100.0000%> (?)
unit 72.1499% <100.0000%> (+0.7935%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.3807% <ø> (+8.9505%) ⬆️

@winoros
Copy link
Member Author

winoros commented May 13, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label May 14, 2024
@time-and-fate
Copy link
Member

time-and-fate commented May 14, 2024

/hold

waiting for test cases

Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-13 16:19:40.141915793 +0000 UTC m=+1497333.899051368: ☑️ agreed by AilinKid.
  • 2024-05-14 03:45:04.930091917 +0000 UTC m=+1538458.687227492: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
Copy link

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@winoros
Copy link
Member Author

winoros commented May 16, 2024

/unhold first, try to provide a test later

@winoros
Copy link
Member Author

winoros commented May 16, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6612270 into pingcap:master May 16, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #53322.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 16, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #53323.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 16, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53324.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53325.

@winoros winoros deleted the column-prune-shallow-copy-slice branch May 16, 2024 07:53
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid memory address or nil pointer dereference in (*SortedRowContainer).Add
5 participants