Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix charset conversion warning and error behavior (#51191) #53227

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51191

What problem does this PR solve?

Issue Number: close #50295

Problem Summary:

The error cannotConvertString should have three different behaviors:

  1. Explicit cast, and SQL_MODE is strict: it'll return NULL and add a warning.
  2. Explicit cast, and SQL_MODE is not strict: it'll return truncated string and add a warning.
  3. Implicit cast: it'll return an error.

TiDB returns error in all cases, so it's not compatible.

What changed and how does it work?

Fix the behavior of from_binary function. Now it's only fixed on TiDB, and will need some modification on TiKV as well.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-13 08:31:36.946457442 +0000 UTC m=+1469250.703593010: ☑️ agreed by Defined2014.
  • 2024-05-13 08:32:24.623795144 +0000 UTC m=+1469298.380930720: ☑️ agreed by YangKeao.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@2a04b9c). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53227   +/-   ##
================================================
  Coverage               ?   71.1536%           
================================================
  Files                  ?       1465           
  Lines                  ?     421218           
  Branches               ?          0           
================================================
  Hits                   ?     299712           
  Misses                 ?     101022           
  Partials               ?      20484           
Flag Coverage Δ
unit 71.1536% <56.2500%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9806% <0.0000%> (?)

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2024
Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, YangKeao, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 14, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit d774c73 into pingcap:release-8.1 May 15, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants