Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614) #45944

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45614

What problem does this PR solve?

Issue Number: close #45427

Problem Summary:

lightning wrongly use int64 to save NEXT_GLOBAL_ROW_ID.

pingcap/tiflow#9391 (comment)

What is changed and how it works?

https://github.com/pingcap/tidb/blob/f1b9da103166162944ae41dc0943c93c0b91923b/br/pkg/lightning/backend/tidb/tidb.go#L847C1-L852

nextID's type is changed to string.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@f028669). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45944   +/-   ##
================================================
  Coverage               ?   74.2405%           
================================================
  Files                  ?       1083           
  Lines                  ?     351118           
  Branches               ?          0           
================================================
  Hits                   ?     260672           
  Misses                 ?      74076           
  Partials               ?      16370           

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 10:51:05.104394218 +0000 UTC m=+628229.653410206: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2023
@lyzx2001
Copy link
Contributor

/cc @lance6716

@ti-chi-bot ti-chi-bot bot requested a review from lance6716 August 15, 2023 10:55
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 4973f87 into pingcap:release-6.5 Aug 15, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants