lightning: save NEXT_GLOBAL_ROW_ID as uint64 instead of int64 (#45614) #45941
Conversation
ti-chi-bot
added
needs-1-more-lgtm
release-note-none
size/XS
|
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
size/S
|
/cc @lance6716 |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test unit-test |
|
@lyzx2001: No presubmit jobs available for pingcap/tidb@release-5.3 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@lyzx2001: No presubmit jobs available for pingcap/tidb@release-5.3 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
|
/cc @lance6716 |
| @@ -267,7 +267,7 @@ func (m *dbTableMetaMgr) AllocTableRowIDs(ctx context.Context, rawRowIDMax int64 | |||
| found := false | |||
| for _, info := range autoIDInfos { | |||
| if strings.ToLower(info.Column) == autoIDField { | |||
| maxRowIDMax = info.NextID - 1 | |||
| maxRowIDMax = int64(info.NextID) - 1 | |||
There was a problem hiding this comment.
this should also be changed to uint64 rather than cast it to int64. otherwise we can't handle the large values like 10942694589135710585. But I think many old codes already assume the rowID type is int64 and I'm not sure we can change them 🤔 Will take a look later
ti-chi-bot
bot
added
size/M
|
This pull request is closed because its related version has closed automatic cherry-picking. https://prow.tidb.net/command-help#cherrypick |
This is an automated cherry-pick of #45614
What problem does this PR solve?
Issue Number: close #45427
Problem Summary:
lightning wrongly use
int64to saveNEXT_GLOBAL_ROW_ID.pingcap/tiflow#9391 (comment)
What is changed and how it works?
https://github.com/pingcap/tidb/blob/f1b9da103166162944ae41dc0943c93c0b91923b/br/pkg/lightning/backend/tidb/tidb.go#L847C1-L852
nextID's type is changed tostring.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.