Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump K8s to v1.28.5 #5495

Merged
merged 8 commits into from
Jan 10, 2024
Merged

bump K8s to v1.28.5 #5495

merged 8 commits into from
Jan 10, 2024

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Jan 3, 2024

What problem does this PR solve?

Bump the K8s deps to v1.27.9 and then to v1.28.5

for v1.27:

for v1.28

also ref

why do we need to bump to v1.28, not v1.27

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu January 3, 2024 09:05
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7dc2d75) 61.37% compared to head (68fb4c2) 67.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5495      +/-   ##
==========================================
+ Coverage   61.37%   67.07%   +5.70%     
==========================================
  Files         234      245      +11     
  Lines       29947    33808    +3861     
==========================================
+ Hits        18379    22678    +4299     
+ Misses       9727     9249     -478     
- Partials     1841     1881      +40     
Flag Coverage Δ
e2e 46.12% <85.71%> (?)
unittest 61.38% <ø> (+0.01%) ⬆️

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc csuzhangxc changed the title bump K8s to v1.27.9 [WIP] bump K8s to v1.27.9 Jan 4, 2024
@csuzhangxc csuzhangxc changed the title [WIP] bump K8s to v1.27.9 [WIP] bump K8s to v1.28.5 Jan 10, 2024
@csuzhangxc csuzhangxc changed the title [WIP] bump K8s to v1.28.5 bump K8s to v1.28.5 Jan 10, 2024
@csuzhangxc
Copy link
Member Author

/run-all-tests

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc csuzhangxc merged commit 9a4f5c5 into pingcap:master Jan 10, 2024
12 of 13 checks passed
@csuzhangxc csuzhangxc deleted the k8s-1.27 branch January 10, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants