Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/markdownlint cli #966

Merged
merged 8 commits into from Jul 23, 2021
Merged

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Jul 23, 2021

There's a bug in markdownlint-cli@0.28.0 when using npx. Cause there's no global rc node_modules cache. Maybe we should lock the version.

Error: Cannot find module 'rc'

related: igorshubovych/markdownlint-cli#210

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@breezewish breezewish merged commit e3a27c9 into pingcap:master Jul 23, 2021
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request Jul 23, 2021
shhdgit added a commit that referenced this pull request Jul 23, 2021
* refine: thread safety write intro data (#963)

* Fix/markdownlint cli (#966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants