update to react-router 6

[Fullstop000]

UCP #249

Update to react-router6

Signed-off-by: Fullstop000 fullstop1005@gmail.com

[sre-bot]

@Fullstop000, you already got 300 points from easy level tasks when all pull requests merged. And you will not get score from this PR.

[sre-bot]

Thanks for your contribution. If your PR get merged, you will be rewarded 100 points.

[baurine]

hi @Fullstop000 , thanks for your contribution, I will test and review soon.

[baurine]

Hi @Fullstop000 , after my test, I found some errors, statements / diagnose / search logs / profile pages can't show normally, they are all empty, and the console outputs following errors:

Uncaught Error: Route(...): Nothing was returned from render. This usually means a return statement is missing. Or, to render nothing, return null.

[Fullstop000]

Got something pained after upgrading to react-router v6

[baurine]

Got something pained after upgrading to react-router v6

yep, that's a problem, we need to have a look.

[Fullstop000]

And I got this warning only when unmount AppStatement

[baurine]

And I got this warning only when unmount AppStatement

I will have a look today.

[baurine]

There is some discussion in facebook/react#18178 , I tried to upgrade the react to 16.13.1 , it doesn't dismiss the warning.

It should be caused by the new version react-router, above warning doesn't happen for react-router v5, someone has already reported in remix-run/react-router#7199 as well.

So I think let's wait a few days more to see whether react-router will fix it, if it doesn't, we can merge it first and upgrade it in the future.

[Fullstop000]

So I think let's wait a few days more to see whether react-router will fix it, if it doesn't, we can merge it first and upgrade it in the future.

Sounds reasonable :)

[baurine]

hi @Fullstop000 , react-router fixed above warning in https://github.com/ReactTraining/react-router/releases/tag/v6.0.0-alpha.3 , you can have a try, but unfortunately they removed <Redirect/> component as well which we used, not sure whether it is easy to migrate, if it doesn't, I suggest let update react-router v6 until it is stable, @breeswish , how do you think about it?

[Fullstop000]

Maybe using a history API instead <Redirect/> ? I'll have a try later today.

[breezewish]

@baurine I'm fine with both. This task is not ergant.

[Fullstop000]

@baurine The second warning has been fixed and the first warning only shows on the initial render.

[baurine]

LGTM

[sre-bot]

Team .* complete task #249 and get 100 score, currerent score 1955