Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Bump phpstan version #14571

Merged
merged 7 commits into from Mar 22, 2023
Merged

[Task] Bump phpstan version #14571

merged 7 commits into from Mar 22, 2023

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Mar 8, 2023

Changes in this pull request

Resolves #14495

Additional info

Bumping Version to 1.10.5

@mattamon mattamon added the Task label Mar 8, 2023
@mattamon mattamon added this to the 10.5.19 milestone Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@mattamon
Copy link
Contributor Author

mattamon commented Mar 8, 2023

@blankse, since you have a lot of experience with Phpstan, do you know why this error appears?
It says that the method is unused, but it is clearly called in getConfigTreeBuilder() https://github.com/pimcore/pimcore/blob/10.5/bundles/CoreBundle/DependencyInjection/Configuration.php#L178
Method Pimcore\Bundle\CoreBundle\DependencyInjection\Configuration::addStaticroutesNode() is unused.

@blankse
Copy link
Contributor

blankse commented Mar 8, 2023

@mattamon PhpStan is case sensitive. It is a bug issue here: phpstan/phpstan#8346
But I think we should use the same spelling, right?

@mattamon
Copy link
Contributor Author

mattamon commented Mar 8, 2023

@mattamon PhpStan is case sensitive. It is a bug issue here: phpstan/phpstan#8346 But I think we should use the same spelling, right?

Ah nice yes I just found this issue myself! Of course we should use the same spelling! Thanks for your help!

@mattamon mattamon linked an issue Mar 9, 2023 that may be closed by this pull request
@dvesh3 dvesh3 removed this from the 10.5.19 milestone Mar 13, 2023
@dvesh3 dvesh3 self-assigned this Mar 13, 2023
@robertSt7 robertSt7 added this to the 10.5.20 milestone Mar 15, 2023
@dvesh3 dvesh3 merged commit 64e3a09 into 10.5 Mar 22, 2023
11 checks passed
@dvesh3 dvesh3 deleted the bump-phpstan-version branch March 22, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PhpStan Version Upgrade March
4 participants