Test on Python 3.7-dev

[hugovk]

Note: Python 3.7 currently fails.

There's a fix coming in #924.

[michaelklishin]

I'm hardly a Python expert but looks like distutils version parser does not expect the version this 3.7 package uses?

[hugovk]

I think the problem is in pyev, it compares two StrictVersions, which don't work with the 3.7 dev version. Something like LooseVersion might work.

The last pyev release is this 0.9.0, from 2013.

[lukebakken]

We may want to consider dropping pyev support since it is basically unmaintained. @gmr what do you think?

[gmr]

I'm fine with that. I've got a pattern of use with travis that works pretty good for collective coverage now too. I'll submit a PR that cleans up travis and removes pyev.

[lukebakken]

We'll get this once #937 is merged.

[codecov]

Codecov Report

Merging #934 into master will decrease coverage by 0.3%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   82.42%   82.12%   -0.31%     
==========================================
  Files          20       21       +1     
  Lines        3636     3776     +140     
  Branches      540      560      +20     
==========================================
+ Hits         2997     3101     +104     
- Misses        494      517      +23     
- Partials      145      158      +13

Impacted Files	Coverage Δ
pika/adapters/asyncio_connection.py	58.44% <0%> (-1.3%)	⬇️
pika/adapters/base_connection.py	65.07% <0%> (-0.53%)	⬇️
pika/__init__.py	100% <0%> (ø)	⬆️
pika/adapters/libev_connection.py	73.43% <0%> (ø)
pika/adapters/blocking_connection.py	84.87% <0%> (+0.13%)	⬆️
pika/adapters/__init__.py	77.27% <0%> (+5.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35169f8...d1e18c4. Read the comment docs.

[hugovk]

Rebased, and now PyYAML fails to build on 3.7:

  ext/_yaml.c: In function ‘__Pyx__ExceptionSave’:
  ext/_yaml.c:24143:19: error: ‘PyThreadState’ has no member named ‘exc_type’
       *type = tstate->exc_type;
                     ^
  ext/_yaml.c:24144:20: error: ‘PyThreadState’ has no member named ‘exc_value’
       *value = tstate->exc_value;
                      ^
  ext/_yaml.c:24145:17: error: ‘PyThreadState’ has no member named ‘exc_traceback’
       *tb = tstate->exc_traceback;
                   ^
  ext/_yaml.c: In function ‘__Pyx__ExceptionReset’:
  ext/_yaml.c:24152:22: error: ‘PyThreadState’ has no member named ‘exc_type’
     member named ‘exc_traceback’
       tstate->exc_traceback = local_tb;
             ^
  error: command 'gcc' failed with exit status 1
  
  ----------------------------------------
  Failed building wheel for PyYAML
  Running setup.py clean for PyYAML
Failed to build PyYAML

https://travis-ci.org/pika/pika/jobs/335516418

[hugovk]

I've reported this to PyYAML: yaml/pyyaml#126.

[lukebakken]

@hugovk looks like pinning awscli to version 1.11.18 could work. Waiting on builds now.

[lukebakken]

Well, 3.7.-dev is fixed, but now there's this - @gmr is this due to the older awscli version?

$ aws s3 cp --recursive s3://com-gavinroy-travis/pika/$TRAVIS_BUILD_NUMBER/ coverage
fatal error: Unable to locate credentials
The command "aws s3 cp --recursive s3://com-gavinroy-travis/pika/$TRAVIS_BUILD_NUMBER/ coverage" exited with 1.

[hugovk]

@lukebakken That'll be #937 (comment).

[hugovk]

Good news, PyYAML 4.1 has just been released which now supports Python 3.7: yaml/pyyaml#126.

When aws/aws-cli#3414 is merged to upgrade the PyYAML used by awscli, the awscli version pinning from this PR can be removed.