Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: Remove unnecessary guard #1435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jpmckinney
Copy link

Proposed Changes

self._channel in the cancel callback will have been initialized by the channel open callback (and will not have been nulled by the connection close callback).

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • All tests pass locally with my changes
  • (N/A) I have added tests that prove my fix is effective or that my feature works
  • (N/A) I have added necessary documentation (if appropriate)

self._channel in the cancel callback will have been initialized by the channel open callback (and will not have been nulled by the connection close callback).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant