Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 release checklist #1363

Open
3 tasks
lukebakken opened this issue May 25, 2022 · 6 comments
Open
3 tasks

2.0.0 release checklist #1363

lukebakken opened this issue May 25, 2022 · 6 comments
Assignees
Milestone

Comments

@lukebakken
Copy link
Member

lukebakken commented May 25, 2022

  • Review all example code (especially in the .rst files) 馃帀
  • Modernize setup.py
  • pylint聽#1371 add pylint and formatting to CI
@lukebakken lukebakken added this to the 1.3.0 milestone May 25, 2022
@lukebakken lukebakken self-assigned this May 25, 2022
@lukebakken lukebakken changed the title 1.3.0 release checklist 2.0.0 release checklist Jun 29, 2022
@lukebakken lukebakken modified the milestones: 1.3.0, 2.0.0 Jun 29, 2022
@alfawal
Copy link
Contributor

alfawal commented Feb 17, 2023

I am not sure about the current state of this repo.
Can you adjust the checklist with:

  • Add pre-commit config including flake, black formatter, isort etc.
  • Update the docs taking care of python3 support

@lukebakken
Copy link
Member Author

Update the docs taking care of python3 support

Pika has been Python 3 compatible for some time now.

Add pre-commit config including flake, black formatter, isort etc.

If people would like to add a pre-commit, it's on them. This is our official formatting guide: link

@alfawal
Copy link
Contributor

alfawal commented Feb 17, 2023

Some parts of the docs are using Python 2's methods/docs urls, shouldn't we update them to use 3 instead? or mention both?

@lukebakken
Copy link
Member Author

Some parts of the docs are using Python 2's methods/docs urls, shouldn't we update them to use 3 instead? or mention both?

Thanks for noticing. We'd appreciate a pull request to do so. I'll make a note of it for 2.0

alfawal added a commit to alfawal/pika that referenced this issue Feb 17, 2023
@alfawal
Copy link
Contributor

alfawal commented Feb 17, 2023

Sorry if I am using this issue for unrelated questions.
Shouldn't you drop the support for python2?
I think the code looks ugly with it and is hard to read, the structure of the repo code looks good but it needs to be modernized in someway, don't you agree?

@lukebakken
Copy link
Member Author

Python 2 support was dropped a while ago and a search of this repo's history would have shown you that.

If you have specific code changes that are more than cosmetic, feel free to open PRs to address them.

lukebakken added a commit that referenced this issue Feb 17, 2023
Feature #1363 -- Bump examples python version to 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants