Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconnecting might better start the loop. proposed minimal fix. #1321

Closed
alexbodn opened this issue Jun 10, 2021 · 3 comments
Closed

reconnecting might better start the loop. proposed minimal fix. #1321

alexbodn opened this issue Jun 10, 2021 · 3 comments
Assignees
Milestone

Comments

@alexbodn
Copy link

hello friends,

studying this example, i came to the conclusion there might be an error.
in case of an unintended connection drop, a loop restart seems more fit to be issued, and not a stop thereof.

self._connection.ioloop.call_later(5, self._connection.ioloop.stop)

@lukebakken lukebakken self-assigned this May 24, 2022
@lukebakken lukebakken added this to the 1.3.0 milestone May 24, 2022
@lukebakken
Copy link
Member

Sorry, I was unsubscribed from this repository and have missed new issues from the past year. I will investigate this before the next release, thank you!

@lukebakken
Copy link
Member

Part of #1363

@lukebakken
Copy link
Member

This code will re-start the connection because self._stopping is still False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants