Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multitype and runtime validations #16

Merged
merged 8 commits into from
May 21, 2023
Merged

Add multitype and runtime validations #16

merged 8 commits into from
May 21, 2023

Conversation

ori-shalom
Copy link
Collaborator

@ori-shalom ori-shalom commented Jan 17, 2023 •
edited

  • Adds runtime validation
  • Add MultiType which can be used to implement oneOf or anyOf.
  • Update schema validations to correctly support oneOf and allOf
  • Fix schema validator for many different cases
  • Waiting for kin-openapi PR #737 to verify runtime errors don't leak PII

@ori-shalom ori-shalom force-pushed the oris/add-runtime-validation-and-support-for-multitype branch 2 times, most recently from 00b5304 to 9bb5c2d Compare January 17, 2023 15:16
@ori-shalom ori-shalom force-pushed the oris/add-runtime-validation-and-support-for-multitype branch from e867f25 to 91a9f02 Compare January 17, 2023 15:24
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

3 similar comments
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

david-sackstein
david-sackstein reviewed May 11, 2023
View reviewed changes
router/binders.go Outdated Show resolved Hide resolved
david-sackstein
david-sackstein reviewed May 11, 2023
View reviewed changes
router/binders.go Outdated Show resolved Hide resolved
david-sackstein
david-sackstein reviewed May 11, 2023
View reviewed changes
router/binders.go Outdated Show resolved Hide resolved
david-sackstein
david-sackstein reviewed May 11, 2023
View reviewed changes
Copy link

@david-sackstein david-sackstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • One of the multitype subtests fails, and I pointed out where the failure is.
  • There are some requests for clarification/simplification of the code.

@ori-shalom ori-shalom force-pushed the oris/add-runtime-validation-and-support-for-multitype branch from 05f4ba6 to e9724a4 Compare May 21, 2023 00:08
@ori-shalom ori-shalom force-pushed the oris/add-runtime-validation-and-support-for-multitype branch 3 times, most recently from 3d35122 to 4c387ae Compare May 21, 2023 01:02
@ori-shalom ori-shalom force-pushed the oris/add-runtime-validation-and-support-for-multitype branch from 5c2bb46 to 1ccaa7f Compare May 21, 2023 01:03
david-sackstein
david-sackstein approved these changes May 21, 2023
View reviewed changes
Copy link

@david-sackstein david-sackstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ori-shalom ori-shalom merged commit e8e010b into main May 21, 2023
@ori-shalom ori-shalom deleted the oris/add-runtime-validation-and-support-for-multitype branch May 21, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-sackstein david-sackstein david-sackstein approved these changes

@nerya10 nerya10 Awaiting requested review from nerya10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ori-shalom @david-sackstein