Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added filter columns for UI #103

Merged
merged 2 commits into from Oct 27, 2021
Merged

Conversation

sinisaos
Copy link
Member

Related to #73

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #103 (f27b6ee) into master (4ce6547) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   98.32%   98.42%   +0.09%     
==========================================
  Files           3        3              
  Lines         179      190      +11     
==========================================
+ Hits          176      187      +11     
  Misses          3        3              
Impacted Files Coverage Δ
piccolo_admin/endpoints.py 98.39% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce6547...f27b6ee. Read the comment docs.

@sinisaos
Copy link
Member Author

@dantownsend Can you check if everything is OK and can you add images to docs. I don't have Safari and it would be good if the images were from the same browser.

@dantownsend
Copy link
Member

@sinisaos This looks great - thanks

@dantownsend
Copy link
Member

@sinisaos Thanks again for this. I added the images to the docs.

I renamed the parameter from filter_columns to visible_filters - I thought it was marginally easier to remember, as it's more similar to the existing visible_columns parameter.

@dantownsend dantownsend merged commit 5f481ef into piccolo-orm:master Oct 27, 2021
@sinisaos sinisaos deleted the filter_columns branch October 28, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants