-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for composite unique constraint in auto migration #984
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #984 +/- ##
==========================================
- Coverage 92.78% 89.72% -3.07%
==========================================
Files 108 109 +1
Lines 8182 8399 +217
==========================================
- Hits 7592 7536 -56
- Misses 590 863 +273 ☔ View full report in Codecov by Sentry. |
@dantownsend I hope it's not a problem, but I have approved and run the workflow for this PR. I have already tried these changes in the @atkei local branch and in my case everything works great as I wrote in this comment. Can you try and review this PR. Thanks. |
@sinisaos @dantownsend - could you make a hint - when it would be merged? Would it mean new version/release? |
@AlexanderMakarov I'll try my best to review it properly this week. |
Currenty looking for this funtionality - would appreciate it someone on the team would be able to review! |
Related to #172, #175 and based on #957.
Add
Constraint
andUniqueConstraint
to support composite unique constraint in auto migraiton.Some work remains such as adding doc and testing, but I would like to have feedback on my proposal first.