Add support for Lilya #977
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 108 108
Lines 8182 8182
=======================================
Hits 7592 7592
Misses 590 590 ☔ View full report in Codecov by Sentry. |
|
@dantownsend not sure how to address this linting situation? Because its complaining about files that I haven't touched? |
piccolo/apps/asgi/commands/new.py
Outdated
| template = Environment( | ||
| loader=FileSystemLoader(searchpath=dir_path) | ||
| ).get_template(file_name) | ||
| template = Environment(loader=FileSystemLoader(searchpath=dir_path)).get_template( |
There was a problem hiding this comment.
@tarsil Linter complains because the line is too long (here and in few other places). Piccolo uses 79 as the line length. Here are the code style docs.
First you need to run linters and formaters locally with this set of commands:
- Run formaters:
./scripts/format.sh - Run linters:
./scripts/lint.sh
That should fix the linting error. Hope that helps.
There was a problem hiding this comment.
@sinisaos perfect. Forgot the format.sh. Done it now.
Appreciated your help on this and now the CI should work fine.
|
@sinisaos now this is odd. I ran exactly those commands and have no problems locally and still complains. Any thoughts? EDIT: I installed again the requirements and run the scripts. |
|
This looks good to me, but I'll let @sinisaos have the final say. |
|
@dantownsend @tarsil It seems good to me too, but I would still try it with |
|
@sinisaos Thanks |
|
Thank you @sinisaos |
|
@dantownsend This works great. @tarsil thanks for your work. Can you add Lilya to |
Thank you 🙂. Done. |
|
Cool, thanks both. |
Adding extra support for Lilya.