Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass M2M join in Table object #566

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

northpowered
Copy link

Adds in piccolo.Table:

  • __join_field coroutine
  • join_m2m coroutine

join_m2m() provides an ability to get M2M related lists of objects, using already defined attributes

Examples are avaliable in docstings of methods and the issue

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #566 (e2a3ce5) into master (0c44bb2) will increase coverage by 0.26%.
The diff coverage is 45.45%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   90.82%   91.08%   +0.26%     
==========================================
  Files         105      108       +3     
  Lines        7183     7541     +358     
==========================================
+ Hits         6524     6869     +345     
- Misses        659      672      +13     
Impacted Files Coverage Δ
piccolo/table.py 91.57% <45.45%> (-4.07%) ⬇️
piccolo/apps/user/commands/create.py 38.88% <0.00%> (-9.03%) ⬇️
piccolo/columns/defaults/time.py 70.83% <0.00%> (-4.78%) ⬇️
piccolo/columns/defaults/timestamp.py 94.54% <0.00%> (-3.38%) ⬇️
piccolo/engine/sqlite.py 93.10% <0.00%> (-3.15%) ⬇️
piccolo/query/methods/insert.py 97.22% <0.00%> (-2.78%) ⬇️
piccolo/apps/playground/commands/run.py 45.23% <0.00%> (-2.67%) ⬇️
piccolo/query/methods/select.py 97.90% <0.00%> (-1.67%) ⬇️
...ccolo/apps/migrations/auto/serialisation_legacy.py 50.00% <0.00%> (-1.52%) ⬇️
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2022

This pull request introduces 2 alerts when merging 9952e81 into 0c44bb2 - view on LGTM.com

new alerts:

  • 2 for Testing equality to None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants