Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tablespace argument to Table #527

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

dantownsend
Copy link
Member

Closes #526

@dantownsend dantownsend added the enhancement New feature or request label May 24, 2022
@dantownsend dantownsend added this to In progress in Enhancements via automation May 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #527 (18711cc) into master (a89c2fa) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
- Coverage   90.75%   90.74%   -0.02%     
==========================================
  Files         104      104              
  Lines        7010     7020      +10     
==========================================
+ Hits         6362     6370       +8     
- Misses        648      650       +2     
Impacted Files Coverage Δ
piccolo/apps/migrations/auto/migration_manager.py 94.56% <ø> (ø)
piccolo/apps/migrations/commands/new.py 98.70% <ø> (ø)
piccolo/query/methods/create.py 92.59% <50.00%> (-3.41%) ⬇️
piccolo/query/methods/create_index.py 94.73% <80.00%> (-2.33%) ⬇️
piccolo/apps/migrations/auto/diffable_table.py 90.47% <100.00%> (+0.15%) ⬆️
piccolo/apps/migrations/auto/schema_differ.py 92.51% <100.00%> (+0.16%) ⬆️
piccolo/table.py 95.67% <100.00%> (+0.01%) ⬆️
piccolo/utils/sync.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89c2fa...18711cc. Read the comment docs.

@dantownsend
Copy link
Member Author

This is pretty much done, but need to work out how to run the unit tests on a Postgres database which uses a custom tablespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Enhancements
In progress
Development

Successfully merging this pull request may close these issues.

Add support for tablespaces
2 participants