Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit set minor and patch version on used actions #746

Merged
merged 3 commits into from Aug 2, 2022
Merged

Conversation

yubiuser
Copy link
Member

  • What does this PR aim to accomplish?:

Same as pi-hole/pi-hole#4833


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser added PR: Approval Required Open Pull Request, needs approval Internal labels Jul 24, 2022
@yubiuser yubiuser requested a review from a team July 24, 2022 20:31
@netlify
Copy link

netlify bot commented Jul 24, 2022

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 5ae55ee
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/62e9776fb37d3d00081ae2cd
😎 Deploy Preview https://deploy-preview-746--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@XhmikosR
Copy link
Contributor

This is definitely not needed and bad practice which will increase the maintenance burden. If a tag is behind, just make an issue upstream.

@yubiuser
Copy link
Member Author

It's not about a missing tag, it's about dependabot. If only major versions are set, it will only upgrade them. If minor and patch are set, it will also upgrade those. I don't see where this increases maintenance burden.

Also, github itself suggests to set the version explicitly. See this comment pi-hole/pi-hole#4833 (comment)

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser merged commit 37e4d65 into master Aug 2, 2022
@yubiuser yubiuser deleted the fix_version branch August 2, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants