Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of deprecations before reducing functions visibility #88

Merged
merged 1 commit into from Sep 19, 2018

Conversation

phsym
Copy link
Owner

@phsym phsym commented Sep 19, 2018

As stated in #87, deprecated a few functions before changing their visibility to private

@phsym phsym added this to the v0.8.0 milestone Sep 19, 2018
@phsym phsym self-assigned this Sep 19, 2018
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files           5        5           
  Lines        1220     1220           
=======================================
  Hits         1030     1030           
  Misses        190      190
Impacted Files Coverage Δ
src/format.rs 68.72% <ø> (ø) ⬆️
src/cell.rs 85.58% <ø> (ø) ⬆️
src/row.rs 90.96% <ø> (ø) ⬆️
src/lib.rs 86.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71800c9...94f7fe6. Read the comment docs.

@phsym phsym merged commit 8e79519 into master Sep 19, 2018
@phsym phsym deleted the deprecations branch September 19, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant