Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of prettytable-rs-derive and the creation of table from vector #110

Closed
wants to merge 0 commits into from

Conversation

thymbahutymba
Copy link

Pull request referring to the issue #109

@thymbahutymba
Copy link
Author

Of course I created a new module for better understand my point of view and the solution that I thought, I was thinking to remove the module and put all code together.

@phsym phsym self-requested a review August 25, 2019 12:09
@phsym
Copy link
Owner

phsym commented Aug 25, 2019

Hi ! Looks promising, thanks. I need to read in more details to understand your code but in the meantime could you please rebase ? I just brought some changes to master which should fix your build in Travis.

@phsym phsym self-assigned this Aug 25, 2019
@phsym phsym added this to the V0.9.0 milestone Aug 25, 2019
@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   84.11%   84.11%           
=======================================
  Files           5        5           
  Lines        1177     1177           
=======================================
  Hits          990      990           
  Misses        187      187
Impacted Files Coverage Δ
src/lib.rs 85.21% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e06ea7...8b7643b. Read the comment docs.

@thymbahutymba
Copy link
Author

Here we are, I rebased the code and I hope I did everything right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants