output-format: add info about editorUrlTitle #8446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janedbal
commented
Dec 1, 2022
| editorUrlTitle: '%%relFile%%:%%line%%' | ||
| ``` | ||
|
|
||
| -------------------- |
There was a problem hiding this comment.
I think the last paragraph should not be considered as 'available since 1.9.3', so I added this line.
staabm
reviewed
Dec 3, 2022
|
|
||
| <div class="text-xs inline-block border border-green-600 text-green-600 bg-green-100 rounded px-1 mb-4">Available in PHPStan 1.9.3</div> | ||
|
|
||
| You may also want to change the default title of the clickable link to contain line to be able to quickly copy-paste it to your IDE when used within an environment that is not clickable (like CI output). Here is how: |
There was a problem hiding this comment.
this sentence is pretty long and hard to read
There was a problem hiding this comment.
What about this?
You may also want to change the default title of the clickable link. For example, CI output may contain [file]:[line] to allow you to quickly copy-paste it to your IDE.
|
Please see #8519 first, for a solution to resolve all |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: phpstan/phpstan-src#2035