Improve autoloading #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyx
force-pushed
the
feature/autoload-composer
branch
from
c9e64fd
to
2b7cd12
Compare
|
ping @ondrejmirtes WDYT? |
|
@shouze @tyx Thanks, I mostly like it. I have some questions/requests:
Other issues I found will be commented in the code. |
ondrejmirtes
requested changes
Dec 27, 2016
| @@ -39,6 +40,11 @@ public function getAliases(): array | |||
|
|
|||
| protected function execute(InputInterface $input, OutputInterface $output): int | |||
| { | |||
| $autoloadFile = $input->getOption('autoload-file'); | |||
| if ($autoloadFile && is_file($autoloadFile)) { | |||
There was a problem hiding this comment.
Please write $autoloadFile !== null.
| if (!is_file($composerAutoloadFile)) { | ||
| $composerAutoloadFile = __DIR__ . '/../../../autoload.php'; | ||
| if (is_file($autoload = getcwd() . '/vendor/autoload.php')) { | ||
| require $autoload; |
No it will not. In this case you should use the new option introduced by @lvht. Without, PHPStan will pop |
tyx
force-pushed
the
feature/autoload-composer
branch
from
f8e0610
to
1555800
Compare
It will allow people to use phpstan globally just by adding their own autoload.php with the path they want inside.
tyx
force-pushed
the
feature/autoload-composer
branch
from
1555800
to
96e1779
Compare
|
ping @ondrejmirtes is it ok to you now? |
Closed
|
This is how I changed the README: c867e71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just get back one part of the @lvht work from #48 as I was going to do the same ^^
I also added another way to customize autoloading like behat does.
The idea is to use phpstan globally on our side