Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in handling constant strings in unions #8568

Closed
staabm opened this issue Dec 21, 2022 · 2 comments · Fixed by phpstan/phpstan-src#2134
Closed

regression in handling constant strings in unions #8568

staabm opened this issue Dec 21, 2022 · 2 comments · Fixed by phpstan/phpstan-src#2134

Comments

@staabm
Copy link
Contributor

staabm commented Dec 21, 2022

Bug report

reported by @schlndh in https://github.com/phpstan/phpstan-src/pull/1979/files#r1053594574

Code snippet that reproduces the problem

https://phpstan.org/r/33df1d6b-50e1-4aed-ac3b-bb5f1a8ac66b

Expected output

non-falsy-string
@staabm staabm mentioned this issue Dec 21, 2022
Merged
@staabm
Copy link
Contributor Author

staabm commented Dec 21, 2022

I have a fix ready, just created the issue to have a bug number for the unit test :)

@staabm staabm mentioned this issue Dec 21, 2022
Merged
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix constant-string handling in union-types staabm/phpstan-src
1 participant
@staabm